Skip to content

(feat): change asset helper to get_theme_file_path to overwrite blocks in child theme#15

Merged
YvetteNikolov merged 2 commits into
mainfrom
feat/change-asset-helper-to-theme-file-path
Jun 24, 2025
Merged

(feat): change asset helper to get_theme_file_path to overwrite blocks in child theme#15
YvetteNikolov merged 2 commits into
mainfrom
feat/change-asset-helper-to-theme-file-path

Conversation

@YvetteNikolov
Copy link
Copy Markdown
Contributor

Hiermee kunnen we blocks in het child theme overschrijven.

@YvetteNikolov YvetteNikolov requested review from a team, Rovasch, SimonvanWijhe, dtakken, hnccox-yard, ictbeheer, mvdhoek1 and robertbossaert and removed request for a team June 23, 2025 15:20
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 23, 2025

Coverage report for commit: c02d709
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 100.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: - | Methods: -
FilesLinesMethodsBranches
src
   BlockServiceProvider.php--100.00%
   Registrar.php--100.00%

🤖 comment via lucassabreu/comment-coverage-clover

Copy link
Copy Markdown

@mvdhoek1 mvdhoek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waar verwees asset() heen eigenlijk?

@YvetteNikolov
Copy link
Copy Markdown
Contributor Author

YvetteNikolov commented Jun 24, 2025

Waar verwees asset() heen eigenlijk?

Altijd naar de public van het huidige thema, zonder fallback naar iets anders.

Deze change naar get_theme_file_path() zorgt ervoor dat er nog als fallback naar het hoofdthema kijkt. Dit is nodig voor de komende opzet met Vite :-)

@YvetteNikolov YvetteNikolov merged commit 84d76be into main Jun 24, 2025
@YvetteNikolov YvetteNikolov deleted the feat/change-asset-helper-to-theme-file-path branch June 24, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants