Conversation
yarikdevcom
reviewed
Feb 14, 2022
yarikdevcom
reviewed
Feb 14, 2022
yarikdevcom
reviewed
Feb 14, 2022
yarikdevcom
reviewed
Feb 14, 2022
yarikdevcom
reviewed
Feb 15, 2022
yarikdevcom
reviewed
Feb 15, 2022
| "client_id": "client123", "nickname": "Cooper123"}) | ||
| assert create_one.status_code == 200 | ||
|
|
||
| query = await container.bot.query() |
Owner
There was a problem hiding this comment.
we don't check here if created_one is inside db by doing query.get(id) and assert for example client_id in json request and db
yarikdevcom
reviewed
Feb 15, 2022
| for _ in range(10)] | ||
| ) | ||
| for item in create_many: | ||
| assert item.status_code == 200 |
Owner
There was a problem hiding this comment.
same here, need to check inside db
yarikdevcom
reviewed
Feb 15, 2022
| nickname=nickname, load=load, max_load=max_load | ||
| ) | ||
| await query.update(updated_bot) | ||
| await query.commit() |
Owner
There was a problem hiding this comment.
you can commit after for loop
| id = bot.dict()["id"] | ||
| print(id) | ||
| await query.delete(id_=id) | ||
| await query.commit() |
Owner
There was a problem hiding this comment.
check her also in db we don not have records
Author
|
next commit will be with adaptation to new changes in main (today-tomorrow) |
yarikdevcom
reviewed
Feb 23, 2022
| ): | ||
| bot: Bot = await query.create(bot_in) | ||
| await query.commit() | ||
| fetch_content.delay(bot.id) |
Owner
There was a problem hiding this comment.
remove for bot, we don't have any background tasks yet
yarikdevcom
reviewed
Feb 23, 2022
| content = providers.Container( | ||
| ContentContainer, resources=resources, config=config.content | ||
| ) | ||
| bot = providers.Container( |
Owner
There was a problem hiding this comment.
should be twitch container -> and inside twitch container you can make bot, and channel containers for query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set db and added tests for bot