Skip to content

test: validate code-review fix (file-based Python args)#3

Open
yashrajsapra wants to merge 3 commits into
mainfrom
test/review-fix-validation
Open

test: validate code-review fix (file-based Python args)#3
yashrajsapra wants to merge 3 commits into
mainfrom
test/review-fix-validation

Conversation

@yashrajsapra
Copy link
Copy Markdown
Owner

Summary

  • Validates the fix in scripts/code-review.sh that reads diff/response from temp files instead of shell-expanding into Python source
  • Previous approach caused SyntaxError: invalid syntax when diff lines like +Sample app... were interpolated into a Python triple-quoted string
  • The sample/buggy_app.py contains deliberate issues for the review to find

What to verify

  • Code Review job posts an actual Claude-generated review (not the fallback message)
  • Review identifies security issues (hardcoded secrets, SQL injection) in buggy_app.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant