feat(conversions): gmc conversions (Merchant API conversions/v1)#95
Merged
Conversation
Adds the conversions/v1 accounts.conversionSources sub-API — the 10th of 11 Merchant API sub-APIs. A conversion source links an account to a conversion-measurement origin: a Merchant Center destination or a Google Analytics property link. New ConversionsService (list/get/create/update/delete/undelete; delete soft-archives, undelete restores via the :undelete colon-verb) and the gmc conversions command group. create takes --ga-property or --merchant-center --currency (or --file); update patches Merchant Center fields via a nested updateMask. Adds the conversions rate-limit bucket and OAuth-scope wiring. Field names, output-only fields, and RPC paths verified against the conversions_v1 discovery document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
conversions/v1accounts.conversionSourcessub-API — the 10th of 11 Merchant API sub-APIs gmc covers. A conversion source links a Merchant Center account to a conversion-measurement origin: a Merchant Center destination or a Google Analytics property link.Commands
gmc conversions list | get <id> | create | update <id> | delete <id> | undelete <id>create—--ga-property <id>(GA link) or--merchant-center --currency <code>(MC destination), or--filefor the full body (e.g. nestedattributionSettings).update— patches Merchant Center fields via a nestedupdateMaskso the rest of the destination is untouched;--file+--update-maskfor full control.deletesoft-archives;undeleterestores (the:undeletecolon-verb).Implementation
ConversionsServicein@gmc-cli/api(mirrorsnotifications), plus new-sub-API plumbing: theconversionsrate-limit bucket and OAuth-scope wiring (SubApi/SUB_APIS in api+auth, DEFAULT_RATE_LIMITS, SUB_API_SCOPES).conversions_v1discovery document.Tests
+23 (api 146, cli 281).
format:check/lint/typecheck/ docs build all clean. Patch bump (api + cli) → v1.0.13.Review
3-agent review (security/quality/API-correctness). Applied: dropped the output-only
destinationfrom the writable path (it's read-only per the discovery doc), markedGoogleAnalyticsLink.attributionSettingsoutput-only,undeletesends the declared empty{}body, tightened the update body type, added a--file --update-masktest.