Repository navigation
fix: evaluate API actor hooks with process credentials - #314
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
yasyf
force-pushed
the
api-actor-public-20261004
branch
from
October 5, 2026 07:31
d84a267 to
1b7ce34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API-authenticated workers need hook judges to use their process credentials. Route marked actors through a per-event evaluator with an explicit provider, one inference attempt, and a deadline that reserves time for child cleanup. Move credentials out of the evaluator environment before loading hooks, and report typed failure metadata without provider error bodies. Unmarked workers keep the resident route.
Apply the current guard-completion contract to the actor route. An incomplete guard produces the existing skip note, while a settled block, explicit deny envelope, or exit 2 remains authoritative. Preserve the current runtime and wire protocol behavior, including background-hook completion within the event deadline.
Require the published spawnllm 0.16.0. Explicit HTTP judges keep their endpoint authentication while receiving the same attempt, timeout, and error handling. Claude judge models with an effort suffix, including the unset Sonnet xhigh default, are refused because the SDK has no Claude effort channel. A transient provider error ends the single attempt.
Synthetic coverage includes credential isolation, error privacy, one-attempt behavior, cleanup, effort refusal, incomplete guards, and settled blocking verdicts. The source worker passed 26 actor Python tests and 24 scoped Go tests; three mutation checks failed as expected. Additional upstream comparison tests recorded 143 passes and one process-limit failure that also reproduced on a 4980 source copy in the same sandbox. CI grades the full current-main candidate. Real authenticated hook execution remains unverified.