Repository navigation
hookd: 馃悰 Resolve releases for the product Python version - #317
Merged
Merged
Conversation
Fresh hosts running Python 3.12 retry the release probe for ten minutes because `uv pip compile` resolves against the host interpreter, while `capt-hook` requires Python 3.13 or later. Read the Python lower bound from the embedded `pyproject.toml` and pass it through `--python-version` so the probe checks the product鈥檚 target interpreter. The existing polling deadline, unpublished-version handling, and errors when `uv` is missing remain covered. This changes the installer probe; the API actor and dependency lock remain unchanged. Validation from the retained Linux source worker: - Five focused Go tests passed, including the older-host regression, polling, deadline, missing executable, and Python-floor parsing. - Removing `--python-version` makes the two resolution regressions fail within their finite deadlines. - A synthetic Python package index tested with actual `uv` 0.12.21 and 0.12.23 resolves the published fixture at Python 3.13 and rejects Python 3.12 and an unpublished version. The worker had no Python 3.12 interpreter, so that target was selected explicitly. Live Ubuntu/Namespace validation follows the released installer; CI grades the full source change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh hosts running Python 3.12 retry the release probe for ten minutes because
uv pip compileresolves against the host interpreter, whilecapt-hookrequires Python 3.13 or later. Read the Python lower bound from the embeddedpyproject.tomland pass it through--python-versionso the probe checks the product鈥檚 target interpreter.The existing polling deadline, unpublished-version handling, and errors when
uvis missing remain covered. This changes the installer probe; the API actor and dependency lock remain unchanged.Validation from the retained Linux source worker:
--python-versionmakes the two resolution regressions fail within their finite deadlines.uv0.12.21 and 0.12.23 resolves the published fixture at Python 3.13 and rejects Python 3.12 and an unpublished version.The worker had no Python 3.12 interpreter, so that target was selected explicitly. Live Ubuntu/Namespace validation follows the released installer; CI grades the full source change.