Repository navigation
fix: retain actor snapshot leases through event settlement - #318
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An API actor can release a snapshot lease after one branch finishes while another branch still borrows the shared graph. Keep deferred cleanup scoped to the actor event, including its awaited background work, and settle the leases and graph before closing the bridge.
Forward the existing
SnapshotClientcleanup option throughclient_scopeand select it forevaluate_actor. Other callers retain immediate cleanup by default. Native claimant, generation, and expiry checks, actor deadlines, and API authentication remain unchanged.The source worker passed six offline
FixtureOwnerregressions covering normal completion and exception unwinding; restoring immediate cleanup makes five cases fail. Related tests passed 95 cases and hit onemcppackage importTypeError, reproduced on the pristine base. Ruff checks and formatting passed. Full CI is pending. The fixture reproduces the source failure sequence; it does not establish which private handle or branch caused every historical warning, and live actor validation remains separate.