docs: 📝 fix a stale retry-transience comment and split the changelog by version - #5
Merged
Merged
Conversation
…by version SidecarError's doc comment claimed a host marks a response transient by pattern-matching the composed message and a bare three-digit number leaking through would read as a retryable 5xx. That stopped being true in v0.13.1 (#4): is_transient now reads only the CLI's last non-empty error line, and counts a 5xx only after a `status` or `API Error` marker, never a bare number, so it now names the keywords (`overloaded`, `rate limit`, `status`/`API Error` 5xx) that interpolated text could actually trip. CHANGELOG.md's Unreleased section carried the 0.12.0, 0.13.0, and 0.13.1 entries with no version headings, because the commits landing the 0.13.0 and 0.13.1 changes never renamed the section the way 4faadf0 did for 0.12.0. Split them under dated `## [0.12.0]`, `## [0.13.0]`, and `## [0.13.1]` headings (attributed by cross-referencing each tag's CHANGELOG.md and commit dates) and added the matching compare links, leaving Unreleased empty. Claude-Session: https://claude.ai/code/session_015yr73szXYEmbjtNVLxnetK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated cleanups:
SidecarError.swift's doc comment still warned that a bare three-digitnumber leaking into a message would read as a retryable 5xx. That stopped
being true in v0.13.1 (retry: 🐛 Classify transient errors from the CLI error line, not echoed prompt #4), where
is_transientstarted requiring astatus/API Errormarker next to the digits. Updated it to name thekeywords (
overloaded,rate limit,status/API Error5xx) thatinterpolated text could actually trip today.
CHANGELOG.md's[Unreleased]section carried the 0.12.0, 0.13.0, and0.13.1 entries with no version headings — the commits that landed the
0.13.0 and 0.13.1 work never renamed the section the way
4faadf0didfor 0.12.0. Split them under dated headings, attributed by cross-checking
each tag's
CHANGELOG.mdand commit dates, and added the compare links.https://claude.ai/code/session_015yr73szXYEmbjtNVLxnetK