Skip to content

Added option to force the targetDir to be the bower dir#87

Open
KyorCode wants to merge 6 commits into
yatskevich:develfrom
KyorCode:devel
Open

Added option to force the targetDir to be the bower dir#87
KyorCode wants to merge 6 commits into
yatskevich:develfrom
KyorCode:devel

Conversation

@KyorCode

@KyorCode KyorCode commented Nov 6, 2013

Copy link
Copy Markdown

I was getting frustrated managing the targetDir and bower directory ( through bower config ). So I added this option to force the bower directory to be overriden with the targetDir option.

bobbor and others added 5 commits August 21, 2013 17:12
so you can have several (different) bower.json-files in multiple
directories
so that bower also knows where you want your packages to be.
Fixed JSHint errors
@manovotny

Copy link
Copy Markdown

Would love to see this added! +1

Comment thread tasks/bower_task.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: missing an "r" in Bower

if(options.overrideBowerDirectory){

@jasonkarns

Copy link
Copy Markdown

+1 This is the way I expected targetDir to work out of the box. (That is, functioning as if directory were set in .bowerrc.)

@freekode

Copy link
Copy Markdown

This is one of the most important things for me :) Please make merge this pull request.

@Ninir

Ninir commented Jan 9, 2014

Copy link
Copy Markdown

@KyorCode Could you fix the issue showed by @cecchi please?
This one would be an awesome one :)

Typo in task fixed
@Ninir

Ninir commented Jan 28, 2014

Copy link
Copy Markdown

@yatskevich Is it mergeable for you?

@KyorCode

KyorCode commented Feb 7, 2014

Copy link
Copy Markdown
Author

would be nice to be added. Makes my npm install a bit cleaner

@KyorCode

Copy link
Copy Markdown
Author

/bump

@mariomc

mariomc commented Apr 7, 2014

Copy link
Copy Markdown

This is a good feature as it deprecates the need of a ".bowerrc" file in your project directory. Still waiting on news for this PR.

@AndrewDryga

Copy link
Copy Markdown

Guys, since author dropped support of this package, i've created new one and merged this pull request into it (among few additional changes): https://github.com/AndrewDryga/grunt-bower-installer

@Nivl

Nivl commented Nov 8, 2014

Copy link
Copy Markdown

bump

@codewithtyler

Copy link
Copy Markdown
Collaborator

@AndrewDryga support has not been dropped for this package. With 13 PRs, 49 issues, and a list of things on the roadmap it's just taking some time to get things implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.