feat(slack): add allowlist controls for agent access - #211
Open
Youcef3939 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pull request introduces new configuration options to control which users and channels the slack plugin will process events from, adding support for allowlists and direct message restrictions. these changes enhance security and flexibility by enabling administrators to restrict access to specific users and channels, and to disable direct message handling if desired. the implementation includes environment variable parsing, enforcement in event handlers, and comprehensive tests
configuration and environment parsing:
allow_dms,user_allowlist, andchannel_allowlistoptions to theSlackPluginConfiginterface, with parsing functions to interpret environment variables (SLACK_ALLOW_DMS,SLACK_USER_ALLOWLIST,SLACK_CHANNEL_ALLOWLIST). [1] [2]slackPluginConfigFromEnvto set defaults and parse the new configuration optionsevent handling and enforcement:
canProcessSlackEventfunction to enforce allowlist and DM restrictions, and integrated it into Slack event handlers to prevent unauthorized events from being processed [1] [2] [3] [4]testing:
these changes provide fine-grained control over which slack events are handled, improving security and compliance for deployments
issue #146
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.