fix(admin): trigger dirty state check on webui models chip removal and addition - #228
Open
elf-mouse wants to merge 1 commit into
Open
fix(admin): trigger dirty state check on webui models chip removal and addition#228elf-mouse wants to merge 1 commit into
elf-mouse wants to merge 1 commit into
Conversation
…d addition
This commit fixes a UI form state bug where clearing all allowed model chips in Admin Governance left the Save button disabled:
1. `plugins/admin/public/index.html`:
- Call `updateSectionDirty("webui-models")` inside chip removal (`x.onclick`), chip addition (`addModel`), and default model selection change handlers.
- Enables administrators to save an empty allowlist to remove model restrictions and restore default catalog visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a UI form state bug where clearing all allowed model chips in Admin Governance left the Save button disabled:
plugins/admin/public/index.html:updateSectionDirty("webui-models")inside chip removal (x.onclick), chip addition (addModel), and default model selection change handlers.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.