Conversation
There was a problem hiding this comment.
Pull request overview
This PR strengthens CST→AST translation soundness results from “ok-value agreement” to full Except equality (including errors), and uses those stronger bridges to prove a new CST validation soundness theorem: validated CST policies do not evaluate to typeError.
Changes:
- Added full-equality (error-preserving) translation soundness theorem
expr_to_expr_soundand supporting mutual soundness lemmas for CST expression translators. - Added full-equality policy-level bridge
policy_to_expr_soundplus supporting evaluation congruence lemmas. - Added equality versions of several helper lemmas in
Aux.lean, and introduced new validation soundness theorems inTranslation.lean.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cedar-lean/Cedar/Thm/Translation/PolicyToExpr.lean | Adds full-Except equality lemmas culminating in policy_to_expr_sound. |
| cedar-lean/Cedar/Thm/Translation/ExprTranslation.lean | Strengthens expression translation soundness to full evaluation equality (including CST-specific errors). |
| cedar-lean/Cedar/Thm/Translation/Aux.lean | Introduces equality versions of helper lemmas used to keep the new soundness proofs modular. |
| cedar-lean/Cedar/Thm/Translation.lean | Switches to equality-based soundness lemmas and adds CST validation soundness theorems. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
victornicolet
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended translation soundness proofs to incorporate errors.
Proved CST policies validation sound -- validated policies don't evaluate to type errors.