Conversation
There was a problem hiding this comment.
Pull request overview
This PR cleans up the CST→AST translation proof stack by removing “agreement-on-.ok” lemmas and their supporting helper theorems, and standardizing on full evaluation equalities for soundness results.
Changes:
- Removed weaker iff-on-
.oksoundness lemmas and related auxiliary bridge lemmas. - Kept/leaned on full
Result-equality soundness theorems (errors included) and updated downstream proofs accordingly. - Simplified some proof/comment structure to match the stronger equality-based approach.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cedar-lean/Cedar/Thm/Translation/PolicyToExpr.lean | Removes weaker per-leaf / policy agreement lemmas and keeps the equality-based soundness path (incl. equality versions of helper bridges). |
| cedar-lean/Cedar/Thm/Translation/ExprTranslation.lean | Removes evaluation-iff lemma families, retaining the equality-based _sound translation theorems. |
| cedar-lean/Cedar/Thm/Translation/Aux.lean | Drops redundant “agreement” helpers in favor of equality versions and adjusts documentation accordingly. |
| cedar-lean/Cedar/Thm/Translation.lean | Updates top-level translation theorems to use full evaluation equalities instead of .ok-iff bridging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed weaker versions of soundness lemmas.
Removed some comments