issue-1541: drain HandleOpsQueue when AsyncDestroy is disabled#6562
issue-1541: drain HandleOpsQueue when AsyncDestroy is disabled#6562WilyTiger wants to merge 2 commits into
Conversation
WilyTiger
added
large-tests
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo.
|
93c73ad to
f603b15
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93c73adcda
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7201s): all tests PASSED for commit f603b15.
|
f603b15 to
31fb9f9
Compare
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7152s): all tests PASSED for commit cd771fe.
|
| const auto path = TFsPath(Config->GetHandleOpsQueuePath()) / | ||
| FileSystemConfig->GetFileSystemId() / | ||
| SessionId; | ||
| if (path.Exists() || asyncDestroyEnabled) { |
There was a problem hiding this comment.
low: should we delete file after drain is finished?
| Config->GetClientId().Quote().c_str())); | ||
| } | ||
| } else if (asyncDestroyEnabled) { | ||
| ReportHandleOpsQueueCreatingOrDeletingError(Sprintf( |
There was a problem hiding this comment.
just curious, will we in that case proceed with nullptr HandleOpsQueue and decided whether we need to use HandlexOpsQueue based only on flags and therefore have a crash?
| std::move(scheduler), | ||
| features); | ||
|
|
||
| bootstrap.Service->CreateSessionHandler = |
There was a problem hiding this comment.
nit: do we need custom handler?
3 participants
Notes
HandleOpsQueue is now restored and drained when AsyncDestroy is disabled if a persistent queue from a previous session exists.
New Release requests continue to use the synchronous path while previously queued DestroyHandle requests are processed in the background.
Issue
#1541