Skip to content

Add certificate expiration metric to the static TLS certificate provider#6594

Open
sharpeye wants to merge 1 commit into
mainfrom
users/sharpeye/cert-counters
Open

Add certificate expiration metric to the static TLS certificate provider#6594
sharpeye wants to merge 1 commit into
mainfrom
users/sharpeye/cert-counters

Conversation

@sharpeye

@sharpeye sharpeye commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Add the ExpireTs metric with the certificate expiration timestamp to the static TLS certificate provider.

@sharpeye sharpeye added large-tests Launch large tests for PR blockstore Add this label to run only cloud/blockstore build and tests on PR filestore Add this label to run only cloud/filestore build and tests on PR storage Add this label to run tests only from cloud/storage/ directory labels Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/storage/ (test time: 65s): all tests PASSED for commit 6d9e926.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
838 838 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7285s): all tests PASSED for commit 6d9e926.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4391 4391 0 0 0 0 0

@sharpeye sharpeye changed the title Pass counters to CreateStaticCertificateProvider; tweak TTlsCertificateProviderTest Pass monitoring counters to static TLS certificate provider Jul 23, 2026
@sharpeye
sharpeye requested a review from yegorskii July 23, 2026 15:02
@sharpeye
sharpeye marked this pull request as ready for review July 23, 2026 15:03
yegorskii
yegorskii previously approved these changes Jul 23, 2026
View reviewed changes
@sharpeye
sharpeye force-pushed the users/sharpeye/cert-counters branch from 106d315 to 15a3f3c Compare July 23, 2026 18:05
@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

@sharpeye
sharpeye force-pushed the users/sharpeye/cert-counters branch from 15a3f3c to 7566def Compare July 23, 2026 18:25
@sharpeye
sharpeye requested a review from yegorskii July 23, 2026 18:26
@sharpeye sharpeye changed the title Pass monitoring counters to static TLS certificate provider Add monitoring counters to the static TLS certificate provider Jul 23, 2026
@sharpeye sharpeye changed the title Add monitoring counters to the static TLS certificate provider Add certificate expiration metric to the static TLS certificate provider Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/storage/ (test time: 73s): all tests PASSED for commit 7566def.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
839 839 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7186s): all tests PASSED for commit 7566def.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4392 4392 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11933s): all tests PASSED for commit 7566def.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
7313 7312 0 0 0 1 0

@sharpeye
sharpeye force-pushed the users/sharpeye/cert-counters branch from 7566def to 721e998 Compare July 24, 2026 12:36
@github-actions

github-actions Bot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/storage/ (test time: 90s): all tests PASSED for commit 721e998.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
839 839 0 0 0 0 0

@sharpeye
sharpeye force-pushed the users/sharpeye/cert-counters branch from 721e998 to 831cbe5 Compare July 24, 2026 13:26
@github-actions

github-actions Bot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/storage/ (test time: 71s): all tests PASSED for commit 831cbe5.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
839 839 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7194s): all tests PASSED for commit 831cbe5.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
4392 4392 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11841s): all tests PASSED for commit 831cbe5.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
7313 7312 0 0 0 1 0

SvartMetal
SvartMetal reviewed Jul 24, 2026
View reviewed changes
Comment thread cloud/storage/core/libs/grpc/tls_certificate_provider.cpp
NTlsUtils::GetCertificateNotAfterTimestampSec(cert.CertChain);
if (HasError(error)) {
STORAGE_WARN(
"Unable to parse certificate notAfter date for "

@SvartMetal SvartMetal Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical event?

@sharpeye sharpeye Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an error occurs here, ExpireTs will be set to zero, which will trigger the expired certificate alerts. I think that should be enough to draw attention to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SvartMetal SvartMetal SvartMetal left review comments
@yegorskii yegorskii yegorskii approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

blockstore Add this label to run only cloud/blockstore build and tests on PR filestore Add this label to run only cloud/filestore build and tests on PR large-tests Launch large tests for PR storage Add this label to run tests only from cloud/storage/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharpeye @SvartMetal @yegorskii