[NBS] Fix NBS shutdown hang when Device Provider socket is missing#6595
[NBS] Fix NBS shutdown hang when Device Provider socket is missing#6595sharpeye wants to merge 1 commit into
Conversation
sharpeye
added
the
blockstore
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. |
bec21be to
4a60c24
Compare
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. |
4a60c24 to
0ec032b
Compare
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1430s): some tests FAILED for commit 0ec032b.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 23s): all tests PASSED for commit 0ec032b.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ec032b7c0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| void Complete() override | ||
| void Complete(bool ok) final |
There was a problem hiding this comment.
Why do we need bool ok?
3 participants
Fix shutdown hanging when the Device Provider socket is unavailable.
The client now cancels active gRPC requests, rejects new requests after shutdown starts, and uses request deadlines.