Fix stale backup metric reporting#205
Merged
Merged
Conversation
added 2 commits
July 8, 2026 12:27
ulya-sidorina
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backups_failed_count/backups_succeeded_countare now recomputed in watchercycle from the last completed backup's status, instead of being set in memory on
backup-completion events. TBWR operations stop retrying after their schedule is deleted.
Behavioral changes
backups yet (this is actually cool, we needed to wait for the first run to see zeros)
failed=1; only a last completed backup in ERROR doesalready-running attempt is left to finish (not aborted in the middle), on success backup still available
without_schedule) metrics are totally unchanged