Skip to content

Fix stale backup metric reporting#205

Merged
ulya-sidorina merged 2 commits into
mainfrom
fix-stale-backup-metric-reporting
Jul 8, 2026
Merged

Fix stale backup metric reporting#205
ulya-sidorina merged 2 commits into
mainfrom
fix-stale-backup-metric-reporting

Conversation

@Jorres

@Jorres Jorres commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

backups_failed_count / backups_succeeded_count are now recomputed in watcher
cycle from the last completed backup's status, instead of being set in memory on
backup-completion events. TBWR operations stop retrying after their schedule is deleted.

Behavioral changes

  • Fixes: alert firing forever for a deleted schedule
  • Metric series disappear within one watcher cycle after a schedule is deleted or deactivated
  • Series now exist (value 0) for every active schedule, including ones with no completed
    backups yet (this is actually cool, we needed to wait for the first run to see zeros)
  • A cancelled backup no longer sets failed=1; only a last completed backup in ERROR does
  • A TBWR whose schedule was deleted finishes as CANCELLED between attempts; an
    already-running attempt is left to finish (not aborted in the middle), on success backup still available
  • Metric updates lag up to one watcher cycle instead of being immediate on completion.
  • on request (without_schedule) metrics are totally unchanged

@ulya-sidorina
ulya-sidorina merged commit ab255c7 into main Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants