Skip to content

Quick Refactoring of Parser.java - srini156#432

Open
srini156 wants to merge 1 commit intoyegor256:masterfrom
srini156:master
Open

Quick Refactoring of Parser.java - srini156#432
srini156 wants to merge 1 commit intoyegor256:masterfrom
srini156:master

Conversation

@srini156
Copy link
Copy Markdown

Changes

  • file is made final & immutable via constructor.
  • Removed duplicate code between getContent() and getContentWithoutUnicode(), using lambda function to filter.
  • Using StringBuilder to construct file content.
  • saveContent method made synchronized for thread safety.

Further enhancements:

  • Use BufferedReader to read characters with charset.
  • Use BufferedWriter to write string contents to the file.
  • Take care of appropriate charset in saveContent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant