refactor: remove unused greet command - #15
Merged
Conversation
Issue: The greet command is a placeholder from Tauri scaffolding that is not
used anywhere in the application.
Changes:
- Remove greet() function from src-tauri/src/lib.rs
- Remove greet from invoke_handler registration
Verification:
- No frontend code calls invoke('greet', ...)
- Command was never part of the application's actual functionality
Note on issue yejiming#9 (reqwest::blocking):
After investigation, reqwest::blocking is actively used by crawler.rs module
for the crawl_fanqie_article command. It cannot be removed without migrating
the entire crawler module to async, which is a larger refactor beyond the
scope of removing unused code.
Test results:
- ✅ 186 Rust unit tests pass
- ✅ TypeScript type check passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
greetcommand, which was a placeholder from Tauri scaffolding that is not used anywhere in the application.Changes
greet()function fromsrc-tauri/src/lib.rsgreetfrominvoke_handlerregistrationVerification
invoke('greet', ...)Note on Issue #9 (reqwest::blocking)
After investigation,
reqwest::blockingis actively used by thecrawler.rsmodule for thecrawl_fanqie_articlecommand:The
blockingfeature cannot be removed without:crawlermodule to asynccrawl_fanqie_articlecommand to asyncreqwest::ClientThis is a larger refactor beyond the scope of removing unused code. Issue #9 may be:
Test Plan
greetin frontend code