Switch from jQuery to vanilla JS#8
Closed
yell0wsuit wants to merge 10 commits into
Closed
Conversation
Owner
yell0wsuit
commented
Jun 4, 2023
yell0wsuit
commented
- Less dependent on jQuery
- Allows offline caching
- Paves ways for moving to single page application (React, Vue.js)
and: - remove some semicolons - indent fixes
No more $!
jQuery Ajax doesn't allow offline caching
✅ Deploy Preview for graceful-chebakia-218e92 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yell0wsuit
added
enhancement
Owner
Author
|
Close this as I have no interest in single page application -- it is a challenge to me lol. |
Owner
Author
Wow. Looking back at this, turn out I actually made it #12. Have to rewrite the app though, but it’s almost done—converting XMLs to JSONs is the final task. |
yell0wsuit
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.