Skip to content

feat(sim): Safe execTransaction ExecutionFailure abort + drift wedge (#17) - #19

Merged
yellowgram merged 1 commit into
mainfrom
feat/i17-safe-exec-failure-abort
Sep 29, 2026
Merged

yellowgram merged 1 commit into
mainfrom
feat/i17-safe-exec-failure-abort

Conversation

@yellowgram

Copy link
Copy Markdown
Owner

Summary

Implements #17 against the LaunchGate eight locks (design gate PASS-with-conditions). Founder GO for implement.

Gate-2 Layer 1 now treats Safe-shaped execTransaction (0x6a761202) specially:

  • Simulated ExecutionFailure → hard abort (-32080) even when outer status is success.
  • Outer success without log/trace inspection → uncertain (fail-open / strict), never definite forward.
  • Abort does not require inner revert bytes (1.3/1.4 event is txHash+payment only); optional debug_traceCall+callTracer enriches copy.
  • Wedge docs: Protocol Kit complementarity + proposal→broadcast drift only — not a Protocol Kit replacement, not a Safe-enterprise / Zodiac / ERC-7579 product.
  • execTransactionFromModule documented as out of P0 residual.
  • Sealed npm run demo:safe-exec is fixture-only (mock upstream; no checkout URL).

Package version stays 0.5.0 (no release bump / publish in this PR).

Not claiming CR4. This is the implement PR for LaunchGate lock compliance review.

LaunchGate lock checklist

# Lock Status
1 Simulated ExecutionFailure → hard abort (never forward as success) Done — V1 logs path + handler fixture (tests/safe.execFailure.test.ts, demo:safe-exec)
2 execTransaction outer success without log/trace ⇒ uncertain Done — applySafeExecCertainty in src/sim/simulator.ts
3 Abort ≠ inner reason; optional callTracer Done — abort on EF topic alone; trace optional for copy/proof
4 Docs: Protocol Kit + proposal→broadcast drift only Done — docs/SAFE_EXEC_DRIFT.md, ARCHITECTURE, README
5 Charter fences (no conversion-pressure / discovery theater; no custody; no Safe replacement / Zodiac / ERC-7579 engine; no mainnet SLA) Done — charter clarified to Safe-enterprise exclusion; Gate-2 EF abort scoped
6 Fixtures: outer-success+ExecutionFailure + GS013 / bubbled-inner Done — tests/safe.execFailure.test.ts
7 Sealed fixture-only demo; no Polar checkout URL Done — npm run demo:safe-exec + docs/fixtures/safe-exec.expected.txt; CI step
8 execTransactionFromModule out of P0 Done — residual in docs/RESIDUAL_BYPASSES.md / SAFE_EXEC_DRIFT

Test plan

  • npm test (151 tests, including 11 new Safe EF cases)
  • npm run lint
  • npm run build && npm run demo:safe-exec
  • npm run demo:dual-layer still passes

)

LaunchGate eight-lock implement for Gate-2 proposal→broadcast drift:

- Hard abort when eth_simulateV1 logs (or debug_traceCall+callTracer)
  show Safe ExecutionFailure, even if outer status is success (-32080).
- execTransaction outer success without log/trace inspection → uncertain.
- Abort does not require inner revert bytes; optional callTracer for copy.
- Fixtures: outer-success+ExecutionFailure, GS013, bubbled Error(string).
- Docs: Protocol Kit complementarity + drift wedge; FromModule residual.
- Sealed npm run demo:safe-exec (fixture-only; no checkout URL).
@yellowgram
yellowgram merged commit dfa2e26 into main Sep 29, 2026
3 checks passed
yellowgram added a commit that referenced this pull request Oct 20, 2026
feat(sim): Safe execTransaction ExecutionFailure abort + drift wedge (#17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant