Skip to content

Conversation

@mckayb
Copy link

@mckayb mckayb commented Feb 2, 2020

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Was using JWT's in a personal project and realized it was logging all of them when they'd make a request. I have a workaround in the app, but figured this was potentially an easy change if you wanted something like that in here.

@snoyberg
Copy link
Member

snoyberg commented Feb 3, 2020

  1. This breaks all of the CI builds
  2. I don't want to make a major version bump for this
  3. If you believe this feature is in fact a breaking change (I tend to agree), please gate it behind some kind of configuration flag so this is a minor version bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants