This repository was archived by the owner on May 8, 2023. It is now read-only.
Print status without formatting if not to terminal#175
Open
jsharps-yext wants to merge 2 commits intoyext:developfrom
Open
Print status without formatting if not to terminal#175jsharps-yext wants to merge 2 commits intoyext:developfrom
jsharps-yext wants to merge 2 commits intoyext:developfrom
Conversation
Enables other services to read the output of edward status
Author
|
Alternatives: Create an interface for the formatter and make the tablewriter one implementer and some quick dealio doo that pops out "foo\tbar\tbaz\n" the other implementation. (kinda like this more than what I have) Flagging on something instead of controlling behavior via output device (don't really care all that much) Also for this to be truly useful the "a new edward version" message should be suppressed when not outputting to terminal |
Author
|
Uploaded the interface one that I liked better because I liked it better. |
theothertomelliott
suggested changes
Mar 19, 2019
| "strings" | ||
| ) | ||
|
|
||
| type tablePrinter interface { |
Contributor
There was a problem hiding this comment.
Perhaps this could live in the terminal package, and define a statusPrinter rather than being table specific?
| rows [][]string | ||
| } | ||
|
|
||
| func NewPlainPrinter(out *os.File) *plainPrinter { |
Contributor
There was a problem hiding this comment.
For versatility, this could be io.Writer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables other tools to read the output of edward status
Too bad I didn't see anything to get rid of those pesky padding spaces in my quick investigation
lol account mixup but whatever