Merge main (v2.0.4) into develop#629
Merged
mkouzel-yext merged 4 commits intodevelopfrom Feb 11, 2026
Merged
Conversation
also update visual test script to not terminate process preemptively
The DropdownItem component currently uses an anchor element with href="#". In the VLE in Storm, if the DropdownItem is clicked, the page tries to call another endpoint, causing the Locator component to get frozen ([relevant slack thread](https://yext.slack.com/archives/C0A1G447MPD/p1770309810738039?thread_ts=1770309450.749689&cid=C0A1G447MPD)). This change converts the DropdownItem component from an `a` element to a `button` element. This is in line with [best practices](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/a#onclick_events), as `a` should only be used for navigation to a real URL rather than triggering JS. This PR also aligns handling for focusing and for hovering over dropdown results. Note that focusing happens by toggling different results with arrow keys, whereas hovering happens by moving the mouse on top of results. We want styling changes to be the same for focusing and hovering. https://yext.atlassian.net/browse/WAT-5384 Before:https://jam.dev/c/51ec9a97-bf37-485f-a6a1-14b8c98e7a76 (note that CSS is not changing properly when focusing on different results) After:https://jam.dev/c/92938750-9cb1-46d0-9b60-f12d9c9984e6
Contributor
Author
|
Current unit coverage is 89.67687788501888% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge main (v2.0.4) into develop