Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mlip.pyand no automated tests, so a small, actionable task list was added to surface prioritized fixes (typo, bug, docs) and a minimal test plan.Description
CODEBASE_REVIEW_TASKS.mdwhich lists four concise tasks: a typo fix to change the section comment# Physics: Lennard-Jones toy label, a bug-hardening task to makesplit_dataset()robust against empty validation splits, a documentation/comment clarification for the inverse-distance descriptor, and a proposal for a minimalpytestsuite covering core invariants.Testing
Codex Task