Conversation
yeze5421
marked this pull request as draft
April 12, 2026 06:26
yeze5421
marked this pull request as ready for review
April 12, 2026 06:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Calculatorwrapper.Description
pyproject.toml,README.md, and two config filesconfigs/minimal.yamlandconfigs/standard.yamlwith sensible defaults.src/mlipx/config.pyand data handling withASEDataset,MLIPDataModule, neighbor graph builder, andGraphBatchtypes undersrc/mlipx/data/.models/layers.py, a PaiNN-style message-passing network inmodels/painn.py, and a high-levelMLIPEnergyModelwithpredict_energy_forcesinmodels/model.py.mlipx.training.engine.Trainerthat handles optimization, LR scheduling, AMP, checkpointing, early stopping, and a CLI entrypointsrc/mlipx/train.pyplusevaluate.pyandinfer.pyfor evaluation and inference workflows.src/mlipx/ase_ext/calculator.pyexposingbuild_calculator, convenience scripts underscripts/(train.sh,evaluate.sh,infer.sh,make_demo_dataset.py,package.sh), project__init__, and utility modules for metrics and seeding.mlip.pyteaching demo and add unit tests intests/to cover the data pipeline and a smoke training/model forward pass.Testing
tests/test_data_pipeline.pyandtests/test_model_and_train.pythat exercise dataset reading, graph collate, model forward and force prediction, and a one-epoch smoke training run using a temporary extxyz dataset.pytest -qand the tests completed successfully.Codex Task