Skip to content

spec: portable-core-contracts - #186

Merged
yihanzhu merged 17 commits into
mainfrom
ystack/spec/portable-core-contracts
Aug 29, 2026
Merged

spec: portable-core-contracts#186
yihanzhu merged 17 commits into
mainfrom
ystack/spec/portable-core-contracts

Conversation

@yihanzhu

Copy link
Copy Markdown
Owner

Tracks #155

What changed

This G2 amendment corrects the frozen review ledger denominator from 31 to 34.

  • Comment 5463604326 has 16 formal findings.
  • Comment 5463851247 has 9 formal findings.
  • Comment 5464015820 has 5 formal findings.
  • Comment 5464192510 has 4 formal findings.

The first three reviews each reported the inactive CI wiring problem. The accepted spec keeps repeated findings as separate ledger rows, so the complete denominator is 34 rather than 31.

Bound evidence

  • Base: 12c3552
  • Head: 8d24727
  • Spec blob: c6511d96c1a5e6aed27ba2075b5add65c121f782
  • Intent blob: f77fc1fdd8f7af228e7f211740901b265fc545ae
  • Risk: high, unchanged

Two independent read-only draft reviews passed. One verified all 34 raw findings and confirmed there is no scope change. The other verified the spec-only merge topology, fresh artifact chain, and frozen attempt state.

The parent plan remains paused and clean at f80a800d573bd32f64afe59d56a8e8d09964dc82, with no open plan PR. PR #183 remains frozen at ab4a708 with round-3 and needs-human.

Approval

Operator merge is the new G2 acceptance for this corrected spec only. It does not approve a plan or code. This PR does not create child issues, add ready state, start implementation, or modify the frozen implementation.

@yihanzhu yihanzhu added the round-0 Review-loop counter: initial PR label Aug 29, 2026
@yihanzhu

Copy link
Copy Markdown
Owner Author

Codex reviewer (cross-vendor, read-only)

Reviewed-head: 8d24727
Reviewed-base: 12c3552
reviewer: operator-default @ high

Posted verbatim by codex-review.sh (codex exec review --json --base refs/codex-review/186-98372/base in an isolated temp worktree, sandbox forced read-only). Comments only — Codex never pushes, approves, or merges.

The patch consistently corrects the review ledger total to 34, with per-comment counts that sum to 34, and updates every related acceptance reference.

@yihanzhu

Copy link
Copy Markdown
Owner Author

Operator action — apply merge-ready, then review and merge

Independent adjudication passed on the exact PR state:

  • head: 8d24727
  • base: 12c3552
  • spec blob: c6511d96c1a5e6aed27ba2075b5add65c121f782
  • final review: comment 5465301808, one exact head marker, one exact base marker, no P0/P1/P2 or actionable finding, no degraded signal
  • checks: ci and Cloudflare Pages both SUCCESS on this head
  • scope: only work/portable-core-contracts/spec.md, 7 additions and 7 deletions

The local approval layer rejected the manager action that would add merge-ready because this automation also coordinated the spec author. No fallback API or second command was used. The PR therefore remains round-0 without merge-ready; #155 remains needs-human and the parent plan stays paused.

Please add the merge-ready label yourself in GitHub. After it is present, review and merge this PR if you accept the exact 31-to-34 correction. Your merge is the new G2 acceptance only. It does not approve the parent plan or any code. If you do not accept it, leave a PR comment instead. No agent will merge.

@yihanzhu
yihanzhu merged commit 7a55da7 into main Aug 29, 2026
2 checks passed
@yihanzhu
yihanzhu deleted the ystack/spec/portable-core-contracts branch August 29, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

round-0 Review-loop counter: initial PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant