Skip to content

Roadmap item 4: Add inactive Codex reviewer payload - #221

Merged
yihanzhu merged 9 commits into
mainfrom
codex/default-codex-native-reviewer-adapter-v1
Sep 2, 2026
Merged

Roadmap item 4: Add inactive Codex reviewer payload#221
yihanzhu merged 9 commits into
mainfrom
codex/default-codex-native-reviewer-adapter-v1

Conversation

@yihanzhu

@yihanzhu yihanzhu commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add an inactive, offline Codex native-review normalizer payload.
  • Validate an untrusted review snapshot against caller-supplied repository, request, review, head, base, app, time, instruction, policy, and execution-boundary bindings.
  • Match the public core content-reference domain, require valid terminal timelines, and bound opaque provider metadata recursively.
  • Keep provider severity and metadata as data, preserve unavailable hidden execution facts, and emit no authority, qualification, write, or activation effect.
  • Document the restore path and add the normalizer and focused test to the required-file manifest.

Scope

Tracks ROADMAP item 4 without closing an intake issue.

This is one payload-only unit. It intentionally ships no adapter manifest or default-profile binding. A later assembly PR must bind the normalizer from its durable squash-main identity, add the manifest, and wire the default set.

The sixth path only adds this focused test to the portable-core schema import guard's closed allowlist. It does not change the guard or core semantics.

The payload is inactive, offline, read-only, and unqualified. It does not invoke a model or CLI, use a credential or network, post a review, change a repository, grant authority, or activate a profile.

Proof

  • scripts/test/default-codex-native-reviewer-adapter.test.sh: 67/67 checks passed with pinned jq 1.6.
  • Public-schema compatibility checks cover valid, exact-boundary, colon, slash, syntax, and media-size cases without importing a selected generation in the product payload.
  • Terminal timeline regressions cover completed, failed, timed-out, and dismissed reviews.
  • Metadata regressions cover snapshot, top-level finding, and inline finding byte, depth, node, container, key, string, and scalar bounds plus canonical repeat.
  • Existing exact bindings, counts, finding states, opaque provider severity, hidden-execution unavailability, stale observations, and read-only output checks remain green.
  • bash -n scripts/test/default-codex-native-reviewer-adapter.test.sh
  • shellcheck -x -S style scripts/test/default-codex-native-reviewer-adapter.test.sh with ShellCheck 0.11.0
  • scripts/check-rename.sh
  • scripts/test/portable-core-schema.test.sh: 47/47 owned rules, 141/141 direct cases, 13/13 private route probes, 8/8 registry cases, 39/39 activation guards, 8/8 numeric boundaries, 8/8 review findings, and 44/44 legacy assertions passed; zero failures.
  • Exact diff, six-path scope, no-manifest/package assertions, and read-only security checks passed.

The branch merged current main at 3c0d4ede3070100084890a4a99944cc97ca94650 without rebasing or force-pushing.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 2, 2026

Copy link
Copy Markdown

Deploying ystack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0723a62
Status: ✅  Deploy successful!
Preview URL: https://307d8d6c.fabrica-6yx.pages.dev
Branch Preview URL: https://codex-default-codex-native-r.fabrica-6yx.pages.dev

View logs

yihanzhu commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

Construction scope approval needed

Required CI failed because the new public-core compatibility test imports schema, but the closed schema-import allowlist does not yet name this test.

Proposed exact change, and nothing else:

  • modify scripts/test/portable-core-schema.test.sh;
  • add scripts/test/default-codex-native-reviewer-adapter.test.sh to schema_import_path_ok, beside the existing GitHub forge adapter test;
  • keep every existing guard and rejection unchanged;
  • PR Roadmap item 4: Add inactive Codex reviewer payload #221 becomes exactly six paths;
  • rerun the Codex adapter targeted suite, portable-core schema proof, exact CI, and fresh independent review.

This is a narrow allowlist synchronization, not a weaker schema guard. The branch remains clean at 3db24d423a61130d76044b395242141a4ca0f2c5; no change was applied after the safety layer rejected the scope expansion.

Please explicitly approve this one sixth-path change.

yihanzhu commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

Codex reviewer (cross-vendor, read-only)

Reviewed-head: 0723a62
Reviewed-base: 3c0d4ed
reviewer: review_codex_payload_221 @ high

Bugs

No Important findings. Terminal timestamps now follow start/terminal/update ordering, with dismissal ordering retained across completed, failed, timed-out, and dismissed reviews. Exact repository, change request, review, head, base, app, observation, counts, finding IDs, ordering, and inline location bindings remain fail closed.

Security

No Important findings. All three provider-metadata locations now have deterministic serialized-size, depth, node, container, key, string, and finite-number bounds. Provider body, severity, and metadata remain opaque and non-authoritative. The payload is pure, offline, read-only, inactive, unqualified, credential-free, network-free, and effect-free.

Compliance

No Important findings. Instruction and review-policy refs match the public core content-ref domain. The approved sixth path adds only this adapter test to the closed schema-import allowlist beside the existing GitHub forge test; it adds no other importer or activation path. Final diff is exactly six authorized paths. Required CI run 33686788763, check 100436059885, app 15368 succeeded. Focused adapter proof passed 67/67 and portable-core schema proof passed with zero failures.

Final review: clean, with zero unresolved Important findings.

@yihanzhu
yihanzhu merged commit 5868e88 into main Sep 2, 2026
2 checks passed
@yihanzhu
yihanzhu deleted the codex/default-codex-native-reviewer-adapter-v1 branch September 2, 2026 22:19

yihanzhu commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

Construction receipt

  • reviewed head/base: 0723a6244553cb30c31a60cd1608a54a880237aa / 3c0d4ede3070100084890a4a99944cc97ca94650
  • required CI: app 15368, run 33686788763, check 100436059885, success
  • final independent review: comment 5517206262, zero unresolved Important
  • squash main: 5868e889ec5ea800ad0e36b99fe583b36b93ec85
  • sole parent: 3c0d4ede3070100084890a4a99944cc97ca94650
  • reviewed/merged tree: a67329b60408a7588adcf64660d820cc2fd32692
  • normalizer blob: 432f09f36f8c93076388e4a26dba56b6ee7a2bf9
  • publisher receipt SHA-256: d9a8b1cb3c99f3cd0721845b6092c75b835007db04d1e62a4938df940fec9c97
  • local main fast-forwarded and clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant