Skip to content

Roadmap item 4: Add inactive deterministic verifier payload - #222

Merged
yihanzhu merged 9 commits into
mainfrom
codex/default-deterministic-verifier-adapter-v1
Sep 3, 2026
Merged

Roadmap item 4: Add inactive deterministic verifier payload#222
yihanzhu merged 9 commits into
mainfrom
codex/default-deterministic-verifier-adapter-v1

Conversation

@yihanzhu

@yihanzhu yihanzhu commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add an inactive, offline deterministic verifier result normalizer.
  • Validate one caller-supplied core v2 verifier request, resolved profile, synthetic manifest contract, and stage result through the existing core relations.
  • Require caller-verified snapshot and stage-result pairs, then bind the exact expected attempt ID and number.
  • Preserve core result, evidence, media, timestamp, candidate, verification-plan, and identity rules.
  • Reject GitHub Actions and other CI observations as verifier evidence.

Scope

Tracks ROADMAP item 4 without closing an intake issue.

This is one payload-only unit. It changes exactly README, RESTORE, the verifier normalizer, the required-file manifest, its focused test, and the portable-core schema import guard. The guard adds only the two exact importer paths for this unit; it adds no wildcard and changes no core rule. This PR intentionally ships no adapter manifest or default-profile binding. A later assembly PR must bind the normalizer from its durable squash-main identity.

This payload normalizes an already-supplied verifier result. It does not execute candidate code or claim that a sandbox or verifier implementation is qualified. A runnable verifier still needs a separately qualified sandbox launcher and fixed implementation.

Safety

The payload is inactive, offline, and unqualified. It does not run a command or tool, read proof bytes, use a credential or network, write evidence or target state, grant authority or qualification, or activate a profile. It accepts no provider metadata and emits no effects.

Exact tuple

  • Base: 5868e889ec5ea800ad0e36b99fe583b36b93ec85
  • Head: 466d658cb7ab8caf160b1c7cc7bc3bfa589f5bc9

Proof

  • scripts/test/default-deterministic-verifier-adapter.test.sh: 46/46 checks passed with pinned jq 1.6.
  • scripts/test/portable-core-schema.test.sh: all 47 owned rules, 141 direct cases, 13 private routes, 8 registry cases, 39 activation guards, 8 numeric boundaries, 8 review findings, and 44 legacy assertions passed; zero failures.
  • Regressions cover caller-verified content, exact attempt identity, stale refs, invalid evidence and media, terminal time order, false passes, protected-role identity, candidate and plan binding, rejected metadata, and the CI/verifier boundary.
  • bash -n: passed.
  • ShellCheck 0.11.0 with -x -S style: passed.
  • Rename, diff, exact six-path, no-manifest, required-file, canonical output, and offline security checks passed.

The branch merged current main normally. It was not rebased or force-pushed.

yihanzhu commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

Construction safety-scope approval needed

The exact #222 candidate deterministically fails the closed schema-import guard. The verifier intentionally consumes the canonical public core schema; replacing it with copied local validators would create schema drift.

Requested exact authorization:

A scan of already-prepared Roadmap units found three more intentional canonical importers. To avoid repeated approval prompts, authorize these exact paths when their own bounded PRs are finalized:

  • scripts/test/default-dormant-publisher-adapter.test.sh
  • adapters/local-git-materializer/v1/protocol.jq
  • evals/v1/framework.jq

No wildcard, no other importer, no generation-ID activation path, and no weakening of existing rejection logic. Each addition lands only with its own unit and must pass exact CI plus fresh independent review.

Current #222 branch remains clean and unchanged at f51092cbab63d12a3d43bcd2b7b0882f558fdc75.

yihanzhu commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

Operator authorization recorded

The operator explicitly approved the five exact named canonical-schema importer paths in the current construction session. No wildcard is authorized.

This PR will add only:

  • adapters/deterministic-verifier/v1/normalize.jq
  • scripts/test/default-deterministic-verifier-adapter.test.sh

to the closed schema_import_path_ok allowlist. The other three approved paths may be added only with their own bounded units. All existing rejection and activation guards remain unchanged.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 2, 2026

Copy link
Copy Markdown

Deploying ystack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c9f070
Status: ✅  Deploy successful!
Preview URL: https://79fea466.fabrica-6yx.pages.dev
Branch Preview URL: https://codex-default-deterministic.fabrica-6yx.pages.dev

View logs

yihanzhu commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

Codex reviewer (cross-vendor, read-only)

Reviewed-head: 466d658
Reviewed-base: 5868e88
reviewer: review_verifier_payload_222 @ high

Final review: not clean.

Important — incident-mismatched execution can carry passed verifier evidence

The selected core v2 relation intentionally preserves mismatched or unclassified execution facts for failed, cancelled, and completed-inconclusive incidents, but it does not enforce the accepted rule that a wrong performer or capability may carry only non-passing evidence.

A fully rehashed completed-inconclusive result using a CI actor and unclassified GitHub Actions capability was accepted with passed deterministic and behavioral verifier evidence. The adapter then emitted the selected verifier identity while omitting those mismatched execution facts.

The root cause belongs in the immutable core result relation. Do not add a duplicated adapter-local guard. Fix the core so any execution mismatch forces all evidence verdicts to be non-passing, then add fully rehashed completed-inconclusive, failed, and cancelled regressions before this PR resumes.

The exact six-path diff and its two authorized schema-import allowlist entries are otherwise clean. Required CI succeeded on the reviewed head, but this Important blocks publication.

yihanzhu commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

Construction root-cause adoption

The current operator-authorized construction session adopts the Important finding in review comment 5517940810 as a Roadmap implementation correction.

Exact concern: incident-mismatch-nonpassing-evidence

Parent selected generation: g-392d20099dfa99872764009b268c8871914b4dbc0da467ec346baa921818ae3e

Required behavior:

  • any passed evidence requires the full observed execution to match the selected projection;
  • an incident execution mismatch may remain only when every evidence verdict is non-passing;
  • failed, cancelled, and completed-inconclusive incident preservation otherwise remains unchanged;
  • historical generations remain byte-identical;
  • no adapter-local workaround, new capability, authority, activation, network, credential, or external effect.

Delivery is two bounded PRs:

  1. add and independently review a complete registered but unselected corrective generation while keeping all current consumers bound coherently to the old selected generation;
  2. atomically switch the wrapper and all exact closure consumers to the reviewed generation.

PR #222 remains paused and unchanged until both land.

@yihanzhu

yihanzhu commented Sep 3, 2026

Copy link
Copy Markdown
Owner Author

Codex reviewer (cross-vendor, read-only)

Reviewed-head: 5c9f070
Reviewed-base: 44a5247
reviewer: operator-default @ high

Posted verbatim by codex-review.sh (codex exec review --json --base refs/codex-review/222-87076/base in an isolated temp worktree, sandbox forced read-only). Comments only — Codex never pushes, approves, or merges.

The normalizer consistently validates the verifier request, profile, manifest, snapshot, result, attempt identity, and timestamp relationships before emitting an inactive, authority-free observation. The accompanying tests and restore manifest updates align with the implementation, and no actionable correctness issue was identified.

@yihanzhu
yihanzhu merged commit 956856d into main Sep 3, 2026
2 checks passed
@yihanzhu
yihanzhu deleted the codex/default-deterministic-verifier-adapter-v1 branch September 3, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant