Conversation
- Add Timeline UI with Bootstrap 5 and renderjson boilerplate - Replace the raw HTML prototype with a polished Bootstrap 5 layout: - Dark navbar with Hudi + checkmark logo - Toolbar with styled input group for table path - State management (empty/loading/error/loaded) with proper visual feedback - Timeline rendered inside a Bootstrap card with instant count badge - Detail card with instant ID, action/state badges, timestamps, and duration - Collapsible JSON tree via renderjson replacing raw JSON.stringify output - CDN-with-bundled-fallback pattern for Bootstrap and renderjson - Thin CSS override file for Hudi-specific colors and vis-timeline tweaks - Parse earliestCommitToRetain and lastCompletedCommitTimestamp from clean metadata and render a semi-transparent background band on the vis-timeline spanning that range. The highlight is removed on deselection or when another instant is selected. - Make InstantDTO and TimelineDTO fields public for Jackson serialization - Add a "Now" button and instant search input to the timeline header in index.html - Highlight clean range on timeline when a clean instant is selected - TimelineHandler now reads metadata for clean, rollback, restore, savepoint, compaction, clustering, and indexing instants instead of returning null. - Avro SpecificRecordBase objects are converted to plain Maps via JsonUtils to avoid serialization errors with AfterburnerModule. - Display "Clean Range" text inside the highlighted band so users can immediately identify what the shaded region represents. - Add label to clean range background band on timeline - Add summary stats, filter controls, color legend, keyboard nav, URL state, and help modal to Timeline UI - Surfaces at-a-glance health metrics (total instants, by-state counts, time span, avg commit duration) in stat cards. - Add toggle filter pills for state and action types using vis DataView. - Include color legend, arrow-key navigation with Escape to deselect, URL ?path= persistence for bookmarking, and a help modal (? key or navbar button) documenting all controls. - Add instant metadata reading for all action types and timeline navigation controls - Frontend renders a searchable config table, current schema JSON tree with fields summary, and reverse-chronological schema diff cards with added/removed/changed field highlighting. - Include keyboard shortcuts (1/2/3), URL tab persistence, and updated help modal. - Add two new lazy-loaded tabs (Table Config, Schema History) alongside the existing Timeline view. Backend exposes two new endpoints: - GET /v2/hoodie/view/table/config — returns sorted hoodie.properties - GET /v2/hoodie/view/table/schema/history — returns deduplicated schema change history with current schema - Add Table Config and Schema History tabs to Timeline UI - Improve schema history tab to prefer internal schema history from .schema directory for richer evolution tracking, and reorder UI to show Current Fields above Current Schema. - Only rendered for KEEP_LATEST_COMMITS policy, skipped for the first clean. - Fix clean range to show the incremental cleaning scan window: spans from previous clean's earliestCommitToRetain to the current clean's, matching CleanPlanner's logic. - Fix clean range display and improve schema history rendering in Timeline UI. - Serve index.html inline at /ui instead of redirecting to /index.html, so the URL stays clean. - Also align the Completed/Inflight/Requested stats card height with the other summary stat cards.
|
Important Review skippedToo many files! This PR contains 166 files, which is 16 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (166)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of apache#13147 for automated bot review.
Original author: @voonhous
Base branch: master