fix(kk): classify wide abbreviations per occurrence - #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
(abbreviation, follower_char)and can drop later same-key occurrences that need different decisions, producing incorrect splits in cases likeобл.x обл.: қала.Description
realize_per_occurrence=TrueonKK_POLICYinsentencesplit/lang/kazakh.pyso each candidate is classified from its own original context.test_kk_empty_follower_occurrences_are_classified_independentlyintests/lang/test_kazakh.pyasserting theобл.x обл.: қалаexample segments as['обл.', 'x обл.: қала'].regular_follower_overridesfield and only alters realization semantics.Testing
uv run pytest tests/lang/test_kazakh.py tests/regression/test_abbr_dot_normalization.py tests/contract/test_period_classifier.pyand they passed (all tests in that run succeeded).uv run ruff check .anduv run ruff format --check .and they succeeded.uv run pytest --cov=sentencesplit tests/ --color yesand the test run completed successfully (the suite passed with the repository's existing skips/xfails).Codex Task