Fix CI test workflow (MinIO, env, pino-pretty)#48
Closed
PabloSzx wants to merge 5 commits into
Closed
Conversation
Newer minio/minio images no longer bundle the mc client, so the `mc ready local` health check fails. Switch to the HTTP health endpoint which works across all MinIO versions.
The minio/minio image no longer defaults to `server /data`, so it just prints help and exits when used as a GitHub Actions service container (which doesn't support custom commands). Run it as a docker step instead, passing `server /data` explicitly.
Node errors out when --env-file points to a missing file. The init and test steps reference .env.testing which doesn't exist in CI.
pino-pretty is installed as a devDependency but not on the shell PATH in GitHub Actions. Use npx to resolve it from node_modules/.bin.
PabloSzx
changed the title
Member
|
Thanks! That was helpful. I reworked the workflows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI test workflow which was broken by three independent issues:
minio/minioimages no longer default toserver /data, so the container just prints help and exits. GitHub Actions service containers don't support custom commands, so MinIO is now started as a workflow step with the explicitserver /datacommand and acurl-based health check..env.testing:node --env-file .env.testingfails when the file doesn't exist. Addedtouch .env.testingto create an empty one in CI.pino-prettynot on PATH: The binary is installed as a devDependency innode_modules/.binbut not on the CI shell's PATH. Switched tonpx pino-pretty.Test plan