Improve ADB error messages with stderr details#7
Merged
Conversation
Extract stderr from exec.ExitError in all ADB command failures so users see the actual device-side error (e.g. "no such process", "permission denied") instead of just "exit status 1". Also improve context for short reads and inaccessible regions.
ykus4
force-pushed
the
feat/better-error-messages
branch
from
0258f32 to
ed5bd0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract stderr from exec.ExitError in all ADB command failures so users see the actual device-side error (e.g. "no such process", "permission denied") instead of just "exit status 1". Also improve context for short reads and inaccessible regions.