fix bug with map chat being sent to global on page load#761
Open
AcrylonitrileButadieneStyrene wants to merge 1 commit intoynoproject:masterfrom
Open
fix bug with map chat being sent to global on page load#761AcrylonitrileButadieneStyrene wants to merge 1 commit intoynoproject:masterfrom
AcrylonitrileButadieneStyrene wants to merge 1 commit intoynoproject:masterfrom
Conversation
jackssrt
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the config loader reads the
globalMessagekey (controlling the globe in all chat) after it reads the chat index, which causes it to overwrite the message destination with whether or not all chat was set to go to global or map instead of which tab was actually selected.this pr fixes that by preventing the all chat globe from driving state when not visible. it is still updated to look correct, and switching to the all tab still switches to the right channel.
an alternative fix would be reordering the other of things being done in the config loader, but to me that seems to be more finicky.
tested with this userscript, and it works: