-
Notifications
You must be signed in to change notification settings - Fork 18
Add 2kki locations: Map3151, 3158 #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was using the previous map argument necessary here? It should only be used in Yume 2kki if there is no other option, as any possibility of warping while on the same map (e.g. use of the Bat effect) will prevent it from working properly.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Map3158 has 2 locations, "Cubic Cliffs" and "Painted Landscape", sharing the same map and coords, causing both to appear.
for bat issue, i believe fixing the location display error should take priority. how about it?
and using bat on this map causes 2kki-side issues, which have already been reported as bugs and should be resolved in the future.(Since bat is not intended for use here)
(additionally, regarding this point, there are other instances of else used in this config, and those will also be affected)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works in that case, as there is no other alternative and the map should not be affected post-fix ultimately.
About the other else cases in the Yume 2kki configs, they are all tied to similar cases, either due to reusing the same coords (e.g. Jigsaw Puzzle World menu, Bleak Future boy balcony which uses the same coordinates than the normal Bleak Future balcony), or to avoid bugs (e.g. the Mask Shop map is set with this argument, as while in the Deluxe Mask Shop, when buying a mask, the game quickly teleports you to the Mask Shop, which leads to a display bug otherwise, and this setting allows avoiding this problem altogether).
It may be possible that some of the cases in it use the argument while not needed, depending on who implemented it and why, but there shouldn't be a lot of them normally and aren't really important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation. Thats very helpful and thanks for the review as well!