remove unused 2kki sprite check#97
Open
AcrylonitrileButadieneStyrene wants to merge 1 commit intoynoproject:masterfrom
Open
remove unused 2kki sprite check#97AcrylonitrileButadieneStyrene wants to merge 1 commit intoynoproject:masterfrom
AcrylonitrileButadieneStyrene wants to merge 1 commit intoynoproject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the code removed is dead code due to the condition never being met. both branches of
isValid2kkiSpritereturn true which is then negated and an if always fails.the
isValid2kkiSpritehas unconditionally returned true since january 2023 when commit fc67d37 flipped the condition but not the base case, causing both to converge.re-enabling the sprite check now would probably cause more problems than it is worth given how outdated the list is.