Skip to content

Fix release workflow - #58

Open
tadeas-hejnic wants to merge 2 commits into
developfrom
set-release-workflow
Open

Fix release workflow#58
tadeas-hejnic wants to merge 2 commits into
developfrom
set-release-workflow

Conversation

@tadeas-hejnic

@tadeas-hejnic tadeas-hejnic commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Changelog Description

Use the new c++ release workflow.

Additional review information

The original one expects to have create_package.py, etc.

Testing notes:

N/A

@tadeas-hejnic tadeas-hejnic self-assigned this Aug 31, 2026
@tadeas-hejnic tadeas-hejnic added the type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) label Aug 31, 2026
@tadeas-hejnic
tadeas-hejnic requested a review from BigRoy August 31, 2026 09:09

@BigRoy BigRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it, but can't confirm whether this is indeed the correct fix? 🤔 Maybe @antirotor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The reusable workflow is pinned to a moving @develop ref, which is a security and reproducibility risk for releases and should be pinned to an immutable ref (tag/SHA) or an agreed stable branch.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Switches this repository’s manual release trigger to call the newer C++-specific reusable release workflow from ynput/ops-repo-automation, aligning the release process with the updated automation expectations (no create_package.py, etc.).

Changes:

  • Update the reusable workflow reference to release_trigger_cpp.yml for C++ releases.
File summaries
File Description
.github/workflows/release_trigger.yml Points the release trigger job at the new C++ reusable release workflow.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

jobs:
call-release-trigger:
uses: ynput/ops-repo-automation/.github/workflows/release_trigger.yml@main
uses: ynput/ops-repo-automation/.github/workflows/release_trigger_cpp.yml@develop

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valid actually @tadeas-hejnic - this should probably point to @main as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's not released in the ops-repo-automation, so this is the reason why it's set to develop

@tadeas-hejnic

Copy link
Copy Markdown
Contributor Author

I don't really know how to test it without merging it... Probably the release of the ops repo should be made first, but I would rather test it before it...

@BigRoy

BigRoy commented Aug 31, 2026

Copy link
Copy Markdown
Member

I don't really know how to test it without merging it... Probably the release of the ops repo should be made first, but I would rather test it before it...

Hmm - I'm no GH workflows expert unfortunately - there must be a way to test it, but I don't know more without just searching around.

@tadeas-hejnic

tadeas-hejnic commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Hmm - I'm no GH workflows expert unfortunately - there must be a way to test it, but I don't know more without just searching around.

Got some guide how to test it and it created the draft release correctly. I think we can merge it, or release the ops-repo-automation first, set the link to main instead of develop and then merge.

+ do the same in other repos

@tadeas-hejnic tadeas-hejnic changed the title use cpp release workflow Fix release workflow Sep 3, 2026
@tadeas-hejnic tadeas-hejnic added the type: bug Something isn't working label Sep 3, 2026
@antirotor

Copy link
Copy Markdown
Member

The change make sense and and yes, this should be changed to main and merged only after ynput/ops-repo-automation is released. BTW there is nothing holding us back on that, right?

@BigRoy

BigRoy commented Sep 4, 2026

Copy link
Copy Markdown
Member

BTW there is nothing holding us back on that, right?

Not that I know of - feel free to push them through.

jobs:
call-release-trigger:
uses: ynput/ops-repo-automation/.github/workflows/release_trigger.yml@main
uses: ynput/ops-repo-automation/.github/workflows/release_trigger_cpp.yml@develop

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: ynput/ops-repo-automation/.github/workflows/release_trigger_cpp.yml@develop
uses: ynput/ops-repo-automation/.github/workflows/release_trigger_cpp.yml@main

since it was merged to main in ynput/ops-repo-automations or we can use tag 0.3.0 directly but main is stable branch so it doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants