Add TDD practices, pre-commit hook, and missing tests#4
Merged
Conversation
- CLAUDE.md updated with mandatory TDD (red-green-refactor), React,
Tailwind, and Git practices
- Pre-commit hook runs build + tests before allowing commits
- 23 new tests for people staging:
- server: pending people API (confirm, merge, dismiss, edge cases)
- python: stage-people.py (generic labels, canonical, staging logic,
skips existing/dismissed/pending, alias matching)
- Branch protection on main: PRs required, no force pushes
- Auto-delete merged branches enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run build+npm testbefore every commit. Committed to.githooks/and enabled viagit config core.hooksPathserver/__tests__/pending-people.test.ts— confirm, merge (with alias dedup), dismiss, 404s, file cleanupscripts/tests/test_stage_people.py— generic label filtering, canonical name merging, skip existing/dismissed/pending, alias matchingTest plan
npm test— 79 tests pass (38 vitest + 41 pytest)