Fix seed-people: replace GENERIC_TOKENS with configurable GENERIC_LABELS#8
Merged
Merged
Conversation
…able file - Removed old GENERIC_TOKENS block (was broken — missing closing brace) - Replaced with trimmed GENERIC_LABELS (15 universal terms) - Added load_generic_labels() for user-defined exclusions via .seam/generic-speakers.txt - is_generic() accepts labels parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup from PR #2 merge. The suggestion commit added
GENERIC_LABELSbut didn't remove the oldGENERIC_TOKENSblock or update references.GENERIC_TOKENSblock (missing closing brace from suggestion commit)is_generic()now usesGENERIC_LABELS(15 universal terms) via parameterload_generic_labels()that merges with user-defined.seam/generic-speakers.txtmain()callsload_generic_labels()for the full exclusion setTest plan
npm run lint— 0 errorsnpm test— 89 tests passpython3 scripts/seed-people.py— runs without errors