Repository navigation
Fix review findings: per-arm Jev counters and corrected experiment docs - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a two-axis code review (standards and spec) of PRs #28 to #36. One code fix and documentation corrections. The standards findings about code style in
experiments/(type hints, docstrings, magic numbers, model names) are not fixed here: they turn on whetherexperiments/should be exempt from the repo rules, which is the owner's decision.Code
experiments/jev_rerank/run.py: one Jev client was shared across arms, so a later arm'sfresh_calls,cost_usdand latency percentiles included the earlier arms. Each Jev arm now gets its own client. The affected results file (run-20261004T033321.json, thejev:v3fields) is left as recorded and annotated in the experiment README; the per-wording figures quoted there were already right.Docs
experiments/jev_rerank/README.mdsaid the rule "bans model names insiderag/andllm/". CLAUDE.md says "No hardcoded model names outside config.py and llm/ backends", sojev-latestandgoogle/gemma-4-12b-qatinexperiments/break it. The README now says so plainly.repeat.jsondoes not store it.No experiment was re-run.
pytestis unaffected: nothing underquarq/ortests/changed.