Repository navigation
Land manifest edits in the project file, let the supervisor settle experiments - #59
Merged
Merged
Conversation
…periments manifest save/patch wrote a store row only, so in a project with files the edit never ran and the next read recorded the old file as a newer version. They now save through the userspace seam like every other kind. The supervisor was told to settle experiments with verdict and author bodies with write_file, and had neither; with one open experiment allowed, its first one held the slot for the session. verdict is on its surface and the prompt names tools it has. A new test checks every tool a role prompt names is on that role's surface; it also caught the reviewer prompt asking for shell and manifest save. Refused manifest, policy and prompt edits are now journaled like cell ones, so they reach the supervisor's brief and later runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manifest save/patch stored a version without writing .samizdat/manifests/, so in file mode a supervisor's manifest edit never ran and the next read recorded the old file on top of it. They now go through the userspace seam.
The supervisor could not call verdict, so its one experiment slot never freed, and its prompt pointed at write_file, which it is deliberately denied. Fixed both, and added a test that every tool a role prompt names is on that role's surface; it also caught the reviewer prompt asking for shell and manifest save.
Refused manifest, policy and prompt edits are journaled now, not just cell ones, so the supervisor's brief sees them.
Full suite green locally (2831 tests).