fix: Replace bash4-only lowercase expansion with bash3.2 compatible tr#165
Open
Rusty-Alucard wants to merge 1 commit into
Open
fix: Replace bash4-only lowercase expansion with bash3.2 compatible tr#165Rusty-Alucard wants to merge 1 commit into
Rusty-Alucard wants to merge 1 commit into
Conversation
${var,,} is a bash 4.0+ feature not available in bash 3.2 (macOS default).
Replace with portable POSIX-compatible tr '[:upper:]' '[:lower:]'.
Fixes startup failure on macOS where /bin/bash is 3.2:
lib/cli_adapter.sh: bad substitution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
lib/cli_adapter.shuses the${var,,}lowercase expansion syntax which is a bash 4.0+ feature. This causes abad substitutionerror on macOS, where the system/bin/bashis version 3.2.Fix
Replace
${cli_type,,}with a POSIX-compatibletrpipeline:Compatibility
/bin/bash)trwhich is universally available)Testing
The
tr '[:upper:]' '[:lower:]'approach correctly lowercases strings on both bash 3.2 and bash 4+, and handles all the alias cases (gemini,agy→antigravity) that the_cli_adapter_normalize_cli_typefunction is designed for.