fix: review follow-ups for #76 — logging, wording, usage-shape test#79
Merged
Conversation
- debug! on the DONE-less clean-EOF break (field-debugging aid for
yoyo-evolve#612-class reports); comment corrected — this eventsource
surfaces every body close as StreamEnded, never a graceful None
- warn! when a non-empty tool-call argument buffer fails to parse
(pre-existing silent unwrap_or({}) fallback now leaves a trace)
- CHANGELOG: truncation 'retries' claim corrected (network drops retry;
deliberate closes fail fast — StreamEnded classifies as Other)
- test: usage chunk after finish_reason + DONE-less close → usage
captured (confirms include_usage shape survives the guard)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two-agent post-merge review of #77. Verdict: the guard is sound (vendored eventsource surfaces body close ONLY as StreamEnded; network drops go Transport→Network→retryable, so the clean-EOF is not over-broad), and the usage-after-finish_reason shape is captured — now proven by a test. Surviving findings applied:
debug!on the DONE-less break + corrected comment (gracefulNoneis unreachable for body close in this lib)warn!when non-empty tool-call args fail to parse (pre-existing silentunwrap_or({})— truncated args no longer vanish traceless)Other, non-retryable); network drops retryinclude_usage-shaped stream (usage chunk after finish_reason, no [DONE]) → usage captured3/3 tests green, clippy clean.
🤖 Generated with Claude Code