Skip to content

yoyo: HTTP MCP: add discussion tools (list, read, create, comment, resolve)#785

Merged
yoyo-evolve[bot] merged 1 commit into
mainfrom
yoyo/issue-783
Jun 26, 2026
Merged

yoyo: HTTP MCP: add discussion tools (list, read, create, comment, resolve)#785
yoyo-evolve[bot] merged 1 commit into
mainfrom
yoyo/issue-783

Conversation

@yoyo-evolve

@yoyo-evolve yoyo-evolve Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Closes #783

Changes

Verification

  • pnpm build passes
  • pnpm lint passes
  • pnpm test passes

Wire list_discussions, read_discussion, create_discussion, add_comment,
and resolve_discussion into the HTTP MCP endpoint. Read tools (list/read)
work without auth; write tools (create/comment/resolve) require auth and
set author from the authenticated principal's handle.

Tests cover tools/list presence, auth gating for all 3 write tools,
read-only access for both read tools, and author attribution from
principal handle.
@yoyo-evolve

yoyo-evolve Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Review passed. Clean wiring of 5 discussion tools into the HTTP MCP surface.

What looks good:

  • All 5 tools follow the established ToolDef pattern exactly — write flags, inputSchema, handler delegation.
  • Auth gating is correct: list_discussions and read_discussion are write: false (no auth); create_discussion, add_comment, resolve_discussion are write: true (auth-gated).
  • author is correctly stamped from p!.handle on create_discussion and add_comment. resolve_discussion intentionally discards the principal (_p), consistent with fix_lint_issue and the upstream handleResolveDiscussion signature which takes no author param.
  • Parameter mappings verified against all 5 handler signatures in src/mcp.ts — all correct.
  • Tests cover all acceptance criteria: tools/list presence, auth rejection for writes, no-auth access for reads, principal attribution for create/comment.
  • No protected files touched. Build, lint, tests all pass (40 tests).

Minimal, correct, complete. Approving.

@yoyo-evolve
yoyo-evolve Bot merged commit bd86cf1 into main Jun 26, 2026
1 check passed
@yoyo-evolve
yoyo-evolve Bot deleted the yoyo/issue-783 branch June 26, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP MCP: add discussion tools (list, read, create, comment, resolve)

0 participants