Repository navigation
Prepare lfguard 0.2.0 policy authoring release - #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e7140395c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| """Serializable Lake Formation state used for desired policy and snapshots.""" | ||
|
|
||
| lf_tags: Tuple[LFTagDefinition, ...] = field(default_factory=tuple) | ||
| lf_tag_key_metadata: Tuple[LFTagKeyMetadata, ...] = field(default_factory=tuple) |
There was a problem hiding this comment.
Preserve positional state constructor arguments
For callers that instantiate the exported DesiredState/CurrentState dataclasses positionally (for example DesiredState(tags, assignments, grants)), inserting lf_tag_key_metadata before the existing fields shifts the old resource_tags argument into metadata and the old grants argument into resource tags, often producing broken serialization or plans with missing grants. Add the new optional field after the existing resource_tags and grants fields (or otherwise prevent positional construction) so existing public API calls keep their meaning.
Useful? React with 👍 / 👎.
Summary
lakeformation_guard.policyauthoring withreader(),editor(),table_creator(), anddatabase_creator()templates.lfguard generate, generated desired-state metadata, bootstrap/pre-commit/GitHub Actions updates, and generic examples.lfguardCLI and publish path.Verification
PYTHONPATH=src python3 -m unittest discover -s testsPYTHONPYCACHEPREFIX=/tmp/lfguard-pycache PYTHONPATH=src python3 -m compileall -q srcgit diff --checklfguard-0.2.0sdist/wheeltwine checklfguard generate/lfguard check