Update README and move the source file to go-mpi/MPI folder.#1
Open
andrewlee302 wants to merge 3 commits into
Open
Update README and move the source file to go-mpi/MPI folder.#1andrewlee302 wants to merge 3 commits into
andrewlee302 wants to merge 3 commits into
Conversation
…the source file to a folder named "MPI" respected to go package naming style.
* Add interface: MPI.Init_thread() Test passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a error in README
MPI.Init() argument datetype is *[]string, so should use &os.Args in the example.
compilation
In experience, an easy understanding way of compiling is setting the cgo enviroments and input "go install go-mpi/MPI" directive.
package name and file dir name should be coherent
package is MPI, so i support moving the source files to a subdirectory MPI.