Skip to content

Simplify redaction module#1

Merged
ypcrts merged 2 commits intomainfrom
simplify-redaction-module
Jan 14, 2026
Merged

Simplify redaction module#1
ypcrts merged 2 commits intomainfrom
simplify-redaction-module

Conversation

@ypcrts
Copy link
Copy Markdown
Owner

@ypcrts ypcrts commented Jan 14, 2026

Note

Refactor: unify redaction module

  • Merge redaction/strategy.rs and redaction/mod.rs into src/redaction.rs, inlining RedactionTarget, RedactionResult, RedactionStrategy, SecureRedactionStrategy, RedactionService, and ffi helpers; add small unit tests.

Tests: increase coverage

  • Expand tests/coverage_gaps_test.rs with cases for full-page redaction, Verizon call-details absent path, unicode paths, custom max_hits, and no-match flows; add domain matcher edge-case tests.

CI: coverage workflow split and caching

  • Move coverage tasks from rust.yml into dedicated coverage.yml; add cargo caching; generate/upload lcov and HTML; add optional Tarpaulin job gated by workflow_dispatch. Remove coverage job from rust.yml and add cargo cache to build job.

Mutation testing config

  • Update mutants.toml to exclude mod ffi in src/redaction.rs instead of the old path.

Written by Cursor Bugbot for commit 918de3d. This will update automatically on new commits. Configure here.

@codecov-commenter
Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ypcrts ypcrts merged commit 80e0bfe into main Jan 14, 2026
4 checks passed
@ypcrts ypcrts deleted the simplify-redaction-module branch January 14, 2026 03:15
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

tarpaulin:
name: Tarpaulin Coverage
runs-on: ubuntu-latest
if: github.event_name == 'workflow_dispatch'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tarpaulin job condition references missing workflow trigger

Medium Severity

The if: github.event_name == 'workflow_dispatch' condition references a trigger that isn't defined in the workflow's on: section. The workflow only triggers on push and pull_request, so workflow_dispatch events will never occur for this workflow. This makes the tarpaulin job unreachable and effectively disables it entirely, rather than making it manually triggerable as presumably intended.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants