Skip to content

game: make endpoints parameters const where possible - #26

Merged
Yamagi merged 9 commits into
yquake2:masterfrom
0lvin:const_api
May 30, 2026
Merged

game: make endpoints parameters const where possible#26
Yamagi merged 9 commits into
yquake2:masterfrom
0lvin:const_api

Conversation

@0lvin

@0lvin 0lvin commented May 1, 2026

Copy link
Copy Markdown
Contributor

Comment thread src/player/client.c Fixed
Comment thread src/player/client.c Fixed
Comment thread src/header/local.h Fixed
Comment thread src/player/client.c Fixed
Comment thread src/player/client.c Fixed
Comment thread src/g_misc.c
@@ -1,3 +1,29 @@
/*
@0lvin
0lvin force-pushed the const_api branch 3 times, most recently from f42118a to 6cf189c Compare May 2, 2026 11:16
Comment thread src/shared/rand.c
* =======================================================================
*/

#include <stdint.h>
@Yamagi

Yamagi commented May 11, 2026

Copy link
Copy Markdown
Member

So far I haven't registered ctf with Coverity. Should I do so?

@0lvin

0lvin commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

So far I haven't registered ctf with Coverity. Should I do so?

Yes, it will be useful as for me. Thank you!

Comment thread src/player/client.c
*/
void
SP_info_player_intermission(edict_t *ent)
SP_info_player_intermission(edict_t *self)
Comment thread src/player/client.c Fixed
@Yamagi

Yamagi commented May 19, 2026

Copy link
Copy Markdown
Member

https://scan.coverity.com/ is currently down. I'm postponing the merge of this PR until I had a chance to register the project with Coverity.

@Yamagi

Yamagi commented May 26, 2026

Copy link
Copy Markdown
Member

It's been 10 days since it went down. I'll give them until the weekend, if they aren't available by them I'll merge this regardless.

@Yamagi

Yamagi commented May 30, 2026

Copy link
Copy Markdown
Member

Mkay, still down. Oh well..

@Yamagi
Yamagi merged commit 13f3331 into yquake2:master May 30, 2026
9 checks passed
@0lvin
0lvin deleted the const_api branch June 4, 2026 20:39
@Yamagi

Yamagi commented Jun 24, 2026

Copy link
Copy Markdown
Member

Coverity is finally available again. I've just registered the project, set the secrets and send you an invite. The project is still waiting for approval.

I've also added a simple modelfile to the ref_vk repo because it was complaining.

And I think you need to accept the invites. It's sending me hints that the invites for yquake/yquake2, yquake2/xatrix, yquake2/rogue and now yquake2/ctf are still pending. I don't know if they'll run into a timeout.

@0lvin

0lvin commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Thank you, I see all yquake2/* projects on dashboard. Ctf shows error on open for me, I suppose because it was not approved.

I will check with yquake2remaster upload in GitHub actions workflows, maybe I made some mistake in workflow changes when tried to ignore upload errors.

@0lvin

0lvin commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

And I think you need to accept the invites. It's sending me hints that the invites for yquake/yquake2, yquake2/xatrix, yquake2/rogue and now yquake2/ctf are still pending. I don't know if they'll run into a timeout.

I suppose that not all services started on their side as result some statuses are incorrect because I see all projects and me as member of them

@Yamagi

Yamagi commented Jun 24, 2026

Copy link
Copy Markdown
Member

That would also explain the cryptic analyze error in ref_vk...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants