vk: size descriptor pool for all sampler consumers - #66
Merged
Conversation
The combined-image-sampler pool was sized MAX_VKTEXTURES + 1, ignoring the lightmap (MAX_LIGHTMAPS * 2), colorbuffer and raw-texture sets that draw from the same pool. On texture- and lightmap-heavy maps the peak demand exceeds the pool, so vkAllocateDescriptorSets in QVk_CreateTexture returns VK_ERROR_OUT_OF_POOL_MEMORY and the renderer aborts. Size both the sampler count and maxSets for the real worst case. Reported in yquake2/yquake2#1323.
Contributor
|
Thank you, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combined-image-sampler pool was sized MAX_VKTEXTURES + 1, ignoring the lightmap (MAX_LIGHTMAPS * 2), colorbuffer and raw-texture sets that draw from the same pool. On texture- and lightmap-heavy maps the peak demand exceeds the pool, so vkAllocateDescriptorSets in QVk_CreateTexture returns VK_ERROR_OUT_OF_POOL_MEMORY and the renderer aborts. Size both the sampler count and maxSets for the real worst case.
Reported in yquake2/yquake2#1323.