[Not to land] Test AndroidDns implementation of Dns.Call#28
Draft
yschimke wants to merge 2 commits into
Draft
Conversation
yschimke
commented
Jul 21, 2026
| } | ||
|
|
||
| try { | ||
| dnsResolver.query( |
Owner
Author
There was a problem hiding this comment.
Instead of dnsResolver.query we should use either
InetAddress.getAllByName()
or
Network.getAllByName()
Which sorts correctly and returns IPv4 and IPv6 together.
Use InetAddress.getAllByName (or Network.getAllByName when a network is set) for A/AAAA resolution instead of DnsResolver query calls, run on a TaskRunner thread. DnsResolver.rawQuery is still used for the HTTPS/ECH record. Update the Robolectric tests accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is 100% vibe coded, not to land. For discussion.